add worklets patch for extra react native host preventing profiling#3604
Merged
Merged
Conversation
|
Review changes with |
sepeterson
approved these changes
May 8, 2026
sepeterson
left a comment
sepeterson
left a comment
Contributor
There was a problem hiding this comment.
Had trouble with this the other day. Much appreciated!
jtklein
approved these changes
May 9, 2026
jtklein
left a comment
jtklein
left a comment
Member
There was a problem hiding this comment.
This works on my end as well. (Also Android still working after the PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Profiling Dev Tools tab is disabled with message "Multiple React Native hosts not supported". This is related to us seeing two duplicate attach options when launching the dev tools through the dev server.
Issue: react-native-community/discussions-and-proposals#954
Comment w/ patch:react-native-community/discussions-and-proposals#954 (reply in thread)
As I understand, this change only affects users debugging against worklets itself.
With this, I am able to start and stop a profiling session and get a result.
Pretty much anything "useful", even a couple taps in under 5s results in the dev tools hanging and becoming unresponsive. I discovered that it eventually completes processing, even if the device's connection with dev tools times out. Once it's done, you get the pop up of "dev tools disconnected. Reconnect? Dismiss?" <- you have to dismiss to get to the actual results or you'll lose the profiling session.
EDIT: it took a while for me to trust that it actually eventually worked consistently. I now trust that it does, one just has to be patient.
Would welcome anyone trying this out!
fixes MOB-1407